Skip to content

Conversation

@dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Sep 26, 2025

Pre-review checklist

  1. Rename workflow files from .yaml to .yml.
  2. Lock and pull python and poetry version from docs/pyproject.toml.
  3. Adds cache to the workflows.
  4. Changes triggering of the workflows to avoid triggering on unreleated changes.
  5. Small workflow formatting changes.
  6. Don't trigger integration test workflow on docs changes.
  7. Update docs dependencies.
  8. Drop poetry in favor of uv
  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev self-assigned this Sep 26, 2025
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch from f83c592 to c9a30ad Compare September 26, 2025 14:37
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch 3 times, most recently from 9cb5785 to 370c01a Compare September 26, 2025 20:01
@dkropachev
Copy link
Collaborator Author

@Lorak-mmk , can you please rereview

@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch 2 times, most recently from 10e217a to 012f312 Compare October 9, 2025 12:41
Currently they are .yaml while rest of the workflows are .yml.
Let's set it inline with the rest.
1. Trigger docs PR check on push to master and on PR events when it
   contains relevant changes
2. Include workflow files into triggering conditions
uv provides better user experience.
As result of switching form poetry to uv environment preparation became seamless, to the point that `setup` step could have been completely dropped.
@dkropachev dkropachev force-pushed the dk/set-docs-workflows-in-order branch from 012f312 to f5611dd Compare October 13, 2025 16:14
Copy link

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you managed to switch docs to uv. I love this, looks great now!

@Lorak-mmk
Copy link

We should switch other repos docs to uv as well.

@dkropachev dkropachev merged commit e851a56 into scylladb:master Oct 19, 2025
16 of 17 checks passed
wprzytula added a commit to scylladb/cpp-rs-driver that referenced this pull request Jan 8, 2026
As requested by @wprzytula 

This is mostly the same set of changes as done in
scylladb/scylla-rust-driver#1528 and
scylladb/python-driver#544
For reliability and better UX, docs are migrated to use UV instead of
poetry.

## Pre-review checklist

<!--
    Make sure you took care of the issues on the list.
    Put 'x' into those boxes which apply.
    You can also create the PR now and click on all relevant checkboxes.
-->

- [x] I have split my patch into logically separate commits.
- [x] All commit messages clearly explain what they change and why.
- [x] PR description sums up the changes and reasons why they should be
introduced.
- [ ] ~~I have implemented Rust unit tests for the features/changes
introduced.~~
- [ ] ~~I have enabled appropriate tests in `Makefile` in
`{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER`.~~
- [ ] ~~I added appropriate `Fixes:` annotations to PR description.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants