forked from apache/cassandra-python-driver
-
Notifications
You must be signed in to change notification settings - Fork 49
Set docs workflows in order #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dkropachev
merged 7 commits into
scylladb:master
from
dkropachev:dk/set-docs-workflows-in-order
Oct 19, 2025
Merged
Set docs workflows in order #544
dkropachev
merged 7 commits into
scylladb:master
from
dkropachev:dk/set-docs-workflows-in-order
Oct 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f83c592 to
c9a30ad
Compare
Lorak-mmk
requested changes
Sep 26, 2025
9cb5785 to
370c01a
Compare
Lorak-mmk
requested changes
Sep 29, 2025
8972a6c to
5fd18f6
Compare
This was referenced Sep 30, 2025
9f26ac0 to
b6910e3
Compare
1 task
Collaborator
Author
|
@Lorak-mmk , can you please rereview |
10e217a to
012f312
Compare
Currently they are .yaml while rest of the workflows are .yml. Let's set it inline with the rest.
1. Trigger docs PR check on push to master and on PR events when it contains relevant changes 2. Include workflow files into triggering conditions
uv provides better user experience. As result of switching form poetry to uv environment preparation became seamless, to the point that `setup` step could have been completely dropped.
012f312 to
f5611dd
Compare
Lorak-mmk
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you managed to switch docs to uv. I love this, looks great now!
|
We should switch other repos docs to uv as well. |
This was referenced Jan 8, 2026
wprzytula
added a commit
to scylladb/cpp-rs-driver
that referenced
this pull request
Jan 8, 2026
As requested by @wprzytula This is mostly the same set of changes as done in scylladb/scylla-rust-driver#1528 and scylladb/python-driver#544 For reliability and better UX, docs are migrated to use UV instead of poetry. ## Pre-review checklist <!-- Make sure you took care of the issues on the list. Put 'x' into those boxes which apply. You can also create the PR now and click on all relevant checkboxes. --> - [x] I have split my patch into logically separate commits. - [x] All commit messages clearly explain what they change and why. - [x] PR description sums up the changes and reasons why they should be introduced. - [ ] ~~I have implemented Rust unit tests for the features/changes introduced.~~ - [ ] ~~I have enabled appropriate tests in `Makefile` in `{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER`.~~ - [ ] ~~I added appropriate `Fixes:` annotations to PR description.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
.yamlto.yml.docs/pyproject.toml.I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.